Don't allow negative values for OS.delay_usec()/OS.delay_msec()
#46194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
os-delay-no-negative
branch
from
a0000da
to
15557e0
Compare
akien-mga
reviewed
Feb 18, 2021
Calinou
force-pushed
the
os-delay-no-negative
branch
from
15557e0
to
76f1f9b
Compare
akien-mga
approved these changes
Feb 18, 2021
I don't think it's a good idea, ms are more convenient to work with than µs IMO. I doubt many users actually use |
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #46190.
PS: In the future, I think we should removeOS.delay_msec()sinceOS.delay_usec()can be used to accomplish the same task (just multiply its argument by 1000). This would limit the maximum delay you can apply from scripting to ~2147 seconds, but I think this should be sufficient.