Fix LineEdit minimum width #45923
Merged
Fix LineEdit minimum width #45923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
commented
Feb 12, 2021
| @@ -394,7 +394,7 @@ void fill_default_theme(Ref<Theme> &theme, const Ref<Font> &default_font, const | |||
| theme->set_color("clear_button_color", "LineEdit", control_font_color); | |||
| theme->set_color("clear_button_color_pressed", "LineEdit", control_font_pressed_color); | |||
|
|
|||
| theme->set_constant("minimum_spaces", "LineEdit", 12 * scale); | |||
| theme->set_constant("minimum_character_width", "LineEdit", 4); | |||
There was a problem hiding this comment.
For reference, this is multiplied by the font, which is usually multiplied by the editor (or theme) scale, so multiplication for scale here was not needed.
reduz
force-pushed
the
fix-lineedit-minimum-width
branch
from
c291810
to
6f70622
Compare
akien-mga
reviewed
Feb 12, 2021
|
@akien-mga ok should be good to merge once it passes CI. |
-Changed theme setting name to make more sense of what it does -Reduced amount of minimum characters, so minimum size is smaller.
akien-mga
force-pushed
the
fix-lineedit-minimum-width
branch
from
10081e3
to
28537d8
Compare
|
Force pushed a rebase for you. |
akien-mga
approved these changes
Feb 12, 2021
|
ah I messed up, thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Changed theme setting name to make more sense of what it does
-Reduced amount of minimum characters, so minimum size is smaller.
As a reference, small LineEdit properties now look fixed:
Supersedes #45922 (which should likely be reverted).Done on top of it, as tab changes were correct.