Allow CollisionObject3D to show collision shape meshes #45783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trollodel
force-pushed
the
collisionobject3d-debug-shapes
branch
from
ece26ba
to
cf454f8
Compare
pouleyKetchoupp
suggested changes
Feb 24, 2021
There was a problem hiding this comment.
This change is very welcome! It also allows debug collision shapes to work with CollisionPolygon3D in game, since it creates a shape internally without using CollisionShape3D.
There's a bug with shapes update though. When I try to modify a shape when the game is running, I end up with both shapes being rendered (the old one and the updated one).
It's probably due to the things I commented in _update_debug_shapes.
Here's my test project:
test-physics-shapes-4.0.zip
trollodel
force-pushed
the
collisionobject3d-debug-shapes
branch
from
cf454f8
to
f6f3a86
Compare
trollodel
force-pushed
the
collisionobject3d-debug-shapes
branch
from
f6f3a86
to
a42a346
Compare
pouleyKetchoupp
suggested changes
Feb 24, 2021
trollodel
force-pushed
the
collisionobject3d-debug-shapes
branch
from
a42a346
to
6b03b85
Compare
pouleyKetchoupp
suggested changes
Feb 24, 2021
Add an editor gizmo to CollisionObject3D. CollisionShape3D no longer shows collision shapes directly.
trollodel
force-pushed
the
collisionobject3d-debug-shapes
branch
from
6b03b85
to
85a776d
Compare
pouleyKetchoupp
approved these changes
Feb 24, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, it is possible to create custom CollisionShape like nodes through the CollisionObject API.
The only limitation (that I found) is that shapes won't show in editor, and in game with "Visible Collision Shapes" active.
This PR addresses this limitation by allowing CollisionObject (only 3D for now) to show shapes directly.
Related to godotengine/godot-proposals#535.
In the left, a CapsuleShape3D added using CollisionShape3D. In the right, a BoxShape3D added using a script.