Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Fix ETC quality setting #44683

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Conversation

madmiraal
Copy link
Contributor

3.2 version of #44682

Note: As stated in #44682, and reproduced here for the benefit of those reading this. This PR leaves the default effort at 0, because the default lossy_quality is 0.7. Therefore there will be no impact to most users. However, anyone using a higher value for the lossy_quality will notice a significant increase in the time it takes to create the VRAM compressed files. As an indication, here are the times in ms I get for importing a 1024x1024 texture to ETC and ETC2 format with this PR:

Lossy Quality ETC ETC2
0.7 797 1,452
> 0.75 4,104 9,284
> 0.85 11,419 36,787
> 0.95 44,267 73,894

The benefit of course is that the textures will have the expected higher quality; even if the artificial adjustment to the effort remains.

@madmiraal madmiraal added this to the 3.2 milestone Dec 25, 2020
@akien-mga akien-mga merged commit 9317251 into godotengine:3.2 Dec 26, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the fix-etc-quality-3.2 branch December 26, 2020 09:40
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants