Cull fixes and optimizations #44656
Merged
Cull fixes and optimizations #44656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just done a test and I'm not sure the quantized version here is working as well as it could, I'm getting about 4 in 20 updates being a noop, versus 19 in 20 with a naive expansion of 0.5 on each axis in my test case (scaled from -10.0 to +10 on each axis with random cubes). Maybe the quantize is scale sensitive, I will look further. |
|
Feel free to continue researching, I wont do a lot more changes to BVH |
lawnjelly
approved these changes
Dec 24, 2020
aaronfranke
reviewed
Jan 23, 2021
| @@ -107,6 +107,9 @@ class AABB { | |||
| Variant intersects_segment_bind(const Vector3 &p_from, const Vector3 &p_to) const; | |||
| Variant intersects_ray_bind(const Vector3 &p_from, const Vector3 &p_dir) const; | |||
|
|
|||
| _FORCE_INLINE_ void quantize(float p_unit); | |||
| _FORCE_INLINE_ AABB quantized(float p_unit) const; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugsquad edit: Follow-up to #44623.