Fixed #42149: bug where the default C# script template would sometimes produce an invalid class name #44515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:3.x
|
Can you review the PR? @akien-mga |
Calinou
approved these changes
Dec 24, 2020
akien-mga
approved these changes
Dec 27, 2020
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
@akien-mga thanks a lot! My first merged open source contribution ever, actually hahaha |
|
Kudos to you! Hopefully the first of many! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
|
Thanks! just checked this ones progress now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42149, where mono would produce invalid class names by not discarding the space's in the object's name.
I simply replace all the spaces with an underscore in the mono code responsible for producing the C# Script template.