Allow renaming to change the case of Windows directories #43068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on Windows 10.
Calinou
added
bug
platform:windows
topic:core
cherrypick:3.x
theraot
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
This change fixes the bug. Tested on Windows 10.
I tried testing on Windows 7, but could not because I could not get Vulkan able drivers. Godot 4 will not run in Vista or XP due to unrelated causes.
I also tried cherry-picking it. The code needs to be changed to use c_str() instead of utf16().get_data() to work in the 3.x branch. With that change the 3.x build worked in Windows 7. So I'm confident this change would have worked for me in Windows 7 if it weren't because Vulkan.
akien-mga
approved these changes
Oct 2, 2021
|
Thanks for the fix, and for the testing and review! Looks good to me too. |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat related to #42992, but different and on Windows.
Here are the steps to reproduce the problem that this fixes:
Error moving: Fooalert and the name is unchangedThis was only a problem with folders. Files already had a fix.
I should point out that the
::_wrename()call used to rename the folders also works on files, so it doesn't seem like the "juggling" workaround in the existing fix is needed anymore, at least on my system.Tested on Windows 10.