[3.x] Add GDScript warning when internal native C++ callback is overridden via script #42968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xrayez
changed the title
|
This can potentially reveal problems with methods which were not exposed as virtual, such as #42093. |
akien-mga
changed the title
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3
to
c58391c
Compare
|
Closing as this contributor can no longer update this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42755.
This introduces a new type of GDScript warning in 3.2 for when a user attempts to override an internal, non-virtual, private callback prefixed with
_in C++ code, which are hidden by default in the documentation and the editor, but nonetheless still accessible through the GDScript code:This may be a problem in 4.0 as well, so upon pre-approval, I could make another PR for the
masterbranch.P.S. This is my first major endeavor at tinkering with GDScript parser code, but this seems to be functional already.