[4.0] [iOS] Switch to ARC. Refactoring and cleanup. #42503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled ARC for iOS. Weakify/Strongify macros for objc blocks. Removed old version checks. Specific types for ObjC++ modules to exclude unneeded bridging. Separate DeviceMetrics class for device specific data. Replaced old/deprecated functionality.
Moved native video handling to separate view.
bruvzg
approved these changes
Oct 2, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled ARC usage to remove requirement to use
retain/release.This should make it easier to update and support iOS platform code. This should also remove potential leaks and crash coming from forgotten/missed or overused
retain/releasecalls.I've also removed some commented old code as suggested in #42459.
But I've left the commented code with iOS 10 functions for a time being as MoltenVK actually supports iOS 9 and it could probably be enabled after some more testing.
DPI and Native video got separate classes with their specific functionality for simplify their support.
I've tested this PR on my iPhone XS with the same project that I had when porting Vulkan. Everything seems okay, but I guess some more testing is needed.
Could probably conflict with #40766, but I'm not sure.