Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Rewrite/Improve LargeTexture #42110

Closed
wants to merge 1 commit into from
Closed

[3.x] Rewrite/Improve LargeTexture #42110

wants to merge 1 commit into from

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Sep 16, 2020

version of #41868 for 3.2

@Calinou Calinou added this to the 3.2 milestone Nov 24, 2020
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga akien-mga changed the title Rewrite/Improve LargeTexture (3.2) [3.x] Rewrite/Improve LargeTexture Mar 26, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@akien-mga
Copy link
Member

So we're removing LargeTexture in 4.0 with #48269, but it will be kept in 3.x to avoid breaking compatibility with the API.

Do you think it's therefore worth it to merge those fixes? They're self-contained so they shouldn't impact the rest of the engine so it might not hurt.

Either way I'd add a deprecation notice in the description of LargeTexture in the class reference so that users know that it's going to be removed in 4.0.

@zaevi zaevi closed this Apr 28, 2021
@zaevi zaevi deleted the fix-LargeTexture-3.2 branch December 2, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug topic:rendering
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@zaevi @akien-mga @Calinou