Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fast approximate antialiasing (FXAA) to Viewport #42006

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add fast approximate antialiasing (FXAA) to Viewport #42006

merged 1 commit into from
Oct 20, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 12, 2020 •
edited
Loading

This backports FXAA from the master branch.

Preview

GLES3

image

GLES2

image

@Calinou Calinou requested a review from reduz as a code owner September 12, 2020 13:24
@Calinou Calinou added this to the 3.2 milestone Sep 12, 2020
@Calinou Calinou requested a review from a team as a code owner September 12, 2020 13:29
@Calinou Calinou force-pushed the add-fxaa-3.2 branch 2 times, most recently from 0470861 to 37f84cd Compare September 12, 2020 20:21
@capnm
Copy link
Contributor

capnm commented Sep 17, 2020

@Calinou why did you move the config from the environment to project settings?

@Calinou
Copy link
Member Author

Calinou commented Sep 17, 2020 •
edited
Loading

@capnm This was done at clayjohn's request for consistency with MSAA. On top of that, all rendering quality settings were moved to the Project Settings in master.

@Calinou Calinou changed the title Add fast approximate antialiasing (FXAA) to Environment Add fast approximate antialiasing (FXAA) to Viewport Sep 17, 2020
@capnm
Copy link
Contributor

capnm commented Sep 17, 2020 •
edited
Loading

Now a project without a default environment shows a completely black 3D viewport ...

@clayjohn
Copy link
Member

@capnm probably just a missed if statement. Is that happening in GLES2 or GLES3?

@capnm
Copy link
Contributor

capnm commented Sep 17, 2020

🐛 is in GLES3.

Pictures

Bildschirmfoto von 2020-09-17 16-21-00
Bildschirmfoto von 2020-09-17 16-21-03

Bildschirmfoto von 2020-09-17 16-22-19
Bildschirmfoto von 2020-09-17 16-22-21

@clayjohn
Copy link
Member

clayjohn commented Sep 17, 2020 •
edited
Loading

@capnm Thanks for the images! However, I can't reproduce. Have you merged this into a custom version of Godot? I see you have some project settings that I don't have. Or maybe you have modified the default environment or something?

Pictures

Screenshot (234)

Screenshot (235)

@capnm
Copy link
Contributor

capnm commented Sep 17, 2020

Have you merged this into a custom version of Godot?

Yes, but that shouldn't interfere here, I'll test it again with the current 3.2 tip.
After deactivating the default environment, you have to restart the editor!

I see you have some project settings that I don't have.

They accumulate and sometimes get stuck in the UI from older 3.2 versions. I'll create new project...

@clayjohn
Copy link
Member

After deactivating the default environment, you have to restart the editor!

I didn't do that. I will try again tonight and see if I can reproduce! I'm sure it will be an easy fix. :)

@capnm
Copy link
Contributor

capnm commented Sep 17, 2020

I didn't do that. I will try again tonight and see if I can reproduce! I'm sure it will be an easy fix. :)

Checked again 3.2 tip + this PR (Linux), removed all old Godot's caches and configs, same issue ;)
test-FXAA2.zip

Pictures

Bildschirmfoto von 2020-09-17 18-07-45

@capnm
Copy link
Contributor

capnm commented Sep 18, 2020

I'm sure it will be an easy fix. :)

In fact it was 👍 Thank you both.

@Calinou @clayjohn
Add fast approximate antialiasing (FXAA) to Viewport
af45c97 
This backports FXAA from the `master` branch.

Co-authored-by: Clay John <claynjohn@gmail.com>
@akien-mga akien-mga merged commit ec10141 into godotengine:3.2 Oct 20, 2020
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the add-fxaa-3.2 branch March 31, 2021 09:46
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
@Calinou Calinou mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawnjelly lawnjelly lawnjelly left review comments

@reduz reduz reduz approved these changes

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
enhancement topic:rendering
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Calinou @capnm @clayjohn @akien-mga @reduz @lawnjelly