Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document RigidBodies in character mode never sleeping automatically #41677

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 1, 2020

See #7996.

@Calinou Calinou requested a review from a team as a code owner September 1, 2020 16:54
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release documentation enhancement labels Sep 1, 2020
@akien-mga akien-mga merged commit 52013cd into godotengine:master Sep 1, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added this to the 4.0 milestone Sep 1, 2020
@akien-mga
Copy link
Member

Cherry-picked for 3.2.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 1, 2020
@Calinou Calinou deleted the doc-rigidbody-sleeping branch September 30, 2020 20:47
@chucklepie
Copy link

Hello, I don't think the documentation for this is fully correct:

[b]Note:[/b] A RigidBody2D will never enter sleep mode automatically if its [member mode] is [constant MODE_CHARACTER]. It can still be put to sleep manually by setting its [member sleeping] property to [code]true[/code].

If sleeping is set to false then setting MODE_CHARACTER turns sleeping to true. I think there should be a documentation update for sleeping not (just) can_sleep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants