Make tilemap lines/rectangles their own tools

[MarcusElg]

Instead of having them as Shift and Shift+CTRL when using the paint tool their are now there own tool. This was discussed a little bit in godotengine/godot-proposals#896. This has many benefits:

• Allows for snapping proporsions etc. I've only implemented snapping proporsions for rectangles but I'm sure shift and control will be used for something useful in the future like maybe snapping the lines to 45 degrees? These kinda stuff aren't currently possible as shift and ctrl are used for rectanges/lines
• Easier to find, I wouldn't exspect a line tool being part of the paint tool as that's not how it works in most other programs

Currently they use the same icon as the paint bucket, I'm defiantly not an artist so I think it's a better idea to let someone else create the icons. Other than that it works pretty well in my testing.

So overall I think this is a good adition which makes it easier to work will tilemaps. Also this allows for adding a eclipse/circle tool in the future if that's wanted. Let me know what you think!

[groud]

Does this disable the current shortcuts with shift and control too? Or it just adds the other tools as another possibility?

Also this allows for adding a eclipse/circle tool in the future if that's wanted.

I personnally don't think it's very useful in tilemap, I'd let this to a plugin I think.

[MarcusElg]

Does this disable the current shortcuts with shift and control too? Or it just adds the other tools as another possibility?

Also this allows for adding a eclipse/circle tool in the future if that's wanted.

I personnally don't think it's very useful in tilemap, I'd let this to a plugin I think.

It removes the shift and control shortcuts because otherwise there would a lot of duplicate code. It does add new shortcuts L and O so using them is just as quick.

Maybe an eclipse tool is unnecceray but this pr doesn't add it so 🤷‍♂️

[groud]

It removes the shift and control shortcuts because otherwise there would a lot of duplicate code. It does add new shortcuts L and O so using them is just as quick.

Hmm, maybe there could be a way to momentarily switch tools? Like holding control would switch to the other tool and releasing it would go back to the other mode.

Anyway, I think this is good enough for now, this is something to think about later on. :)

[MarcusElg]

The Travis CI build could not complete due to an error. WHAT??? Clicking on it says that it was canselled 🤔

[groud]

Weird, I restarted the build.

[akien-mga]

I cancelled it because I want another build to finish in priority, to merge it and cherrypick for 3.2.2 RC 2.

[KoBeWi]

Like holding control would switch to the other tool and releasing it would go back to the other mode.

That's how tile picking works actually. I bet there's a way to have both tools and shortcuts, without the duplicated code.

I personnally don't think it's very useful in tilemap, I'd let this to a plugin I think.

I don't think it's possible to add new tools via plugin.

btw, RPG Maker has ellipse tool. It's useful to draw rounded terrain (e.g. lakes) in top-down games.

[groud]

I don't think it's possible to add new tools via plugin.

I was thinking about implementing that someday

[MarcusElg]

Rebased to once again be mergeable

[MarcusElg]

@akien-mga what is the status? Does it need discussion?

[akien-mga]

Line, rect and bucket fill all use the same bucket icon? That doesn't seem very good UX wise, how do you know which is which?

[MarcusElg]

Line, rect and bucket fill all use the same bucket icon? That doesn't seem very good UX wise, how do you know which is which?

Its suppost to be changed ofcourse. But it's betrer to let someone with experience make the icons. I could make them point to a empty svg if you think that's better.

[groud]

Ah indeed it would be cool to have at least different icons. I believe you could use the editor icon "CurveLinear" for the line and "RectangleShape2D" for the rect tool until someone to make better icons.

[MarcusElg]

@akien-mga @groud it now looks like this;

The rectangle is blue but hopefully someone makes a new icon anyways 🤷‍♂️

[akien-mga]

Thanks!