Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename InputFilter back to Input #38295

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Rename InputFilter back to Input #38295

merged 1 commit into from
Apr 28, 2020

Commits on Apr 28, 2020

  1. Rename InputFilter back to Input 

    It changed name as part of the DisplayServer and input refactoring
in godotengine#37317, with the rationale that input no longer goes through the
main loop, so the previous Input singleton now only does filtering.

But the gains in consistency are quite limited in the renaming, and
it breaks compatibility for all scripts and tutorials that access
the Input singleton via the scripting language. A temporary option
was suggested to keep the scripting singleton named `Input` even if
its type is `InputFilter`, but that adds inconsistency and breaks C#.

Fixes godotengine/godot-proposals#639.
Fixes godotengine#37319.
Fixes godotengine#37690.
    @akien-mga
    akien-mga committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    fdf58a5 View commit details
    Browse the repository at this point in the history