Add antialiased parameter to canvas_item_add_triangle_array #10645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Intel HD4600 And the animation drawn without antilaiased triangles: |
|
duplicate of: #10523 are the other things you do. necessary? It also works without but maybe they are still needed? |
|
@toger5 I think things are necessary to build on windows. |
|
okay so we merge this one than... |
|
Is there any reason to have AA option for triangle array, current AA method (drawing outline with AA lines) is designed for polygons only and will not work for triangle arrays anyway. |
akien-mga
changed the title
|
This PR seems to also fix the ugly editor border issues #10461 |
|
It definitely does! |
Xrayez
added a commit
to goostengine/goost
that referenced
this pull request
Nov 22, 2020
Doesn't work well for closed outlines where drawing is done with triangle array in Godot 3.2, see discussion in: godotengine/godot#10645 Seems to work better for line drawing.
Xrayez
added a commit
to goostengine/goost
that referenced
this pull request
Nov 22, 2020
Doesn't work well for closed outlines where drawing is done with triangle array in Godot 3.2, see discussion in: godotengine/godot#10645 Seems to work better for line drawing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
canvas_item_add_triangle_arrayuse polygon item to draw but it is antilaiased as default so I add this option to make it is possiable to draw triangle arrays without antilaiased.Bugsquad edit: Fixes #10461.