Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnimationTree node and AnimationPlayer node do not show their fields when I click them #63621

Closed
gravit22 opened this issue Jul 29, 2022 · 6 comments · Fixed by #63813
Closed

AnimationTree node and AnimationPlayer node do not show their fields when I click them #63621

gravit22 opened this issue Jul 29, 2022 · 6 comments · Fixed by #63813
Labels
bug regression topic:animation topic:editor
Milestone
4.0

Comments

@gravit22
Copy link

Godot version

Godot 4.0 13 alpha

System information

Ubuntu 22.04 GTX 1060

Issue description

AnimationTree node and AnimationPlayer node do not show their fields when I click them.
Before everything worked fine(in alpha 12 version). I just ckicked the node and field with animations opened when I click AnimationPlayer, for AnimationTree, it is the same problem.
It doesn't work only when you are in scripting mode.

Steps to reproduce

I attached the project.
Just open the project.
Click "Script" tab.
Then click AnimationTree or AnimationPlayer node.
You should not notice any field appear.

Minimal reproduction project

Bug_report.zip
@Calinou Calinou added this to the 4.0 milestone Jul 29, 2022
@tefusion
Copy link
Contributor

This is caused by #63344. Go to editor settings->Text Editor->Behavior->Navigation and disable "Stay In Script Editor On Node Selected", then behavior is the same as in alpha 12.

I think it's intentional, but it might be better to split the setting into two since animation player doesn't switch to another editor and just switches the bottom panel out.

@danhealy
Copy link

danhealy commented Aug 1, 2022

This bug also applies to the MultiplayerSynchronizer / Replication tab.

https://streamable.com/3kamgu

I believe this is a bug, because you can get in a state where you have one MultiplayerSynchronizer node selected but it's actually editing a different node.

https://streamable.com/v2edvp

@alfredbaudisch
Copy link
Contributor

alfredbaudisch commented Aug 2, 2022 •
edited
Loading

This is caused by #63344. Go to editor settings->Text Editor->Behavior->Navigation and disable "Stay In Script Editor On Node Selected", then behavior is the same as in alpha 12.

I think it's intentional, but it might be better to split the setting into two since animation player doesn't switch to another editor and just switches the bottom panel out.

Unfortunately it's not intentional, the AnimationPlayer should still show, because selecting an AnimationPlayer still keeps the Script Editor active even without "Stay In Script Editor On Node Selected". I'll take a look.

@alfredbaudisch alfredbaudisch mentioned this issue Aug 2, 2022
Merged
alfredbaudisch added a commit to alfredbaudisch/godot that referenced this issue Aug 2, 2022
@alfredbaudisch
Display sub-plugins when Stay in Script Editor is On
eaaedb2 
Currently, with stay_in_script_editor_on_node_selected as On, inspector_only is forcibly set, and no editors from the node selected are displayed.

With this change, if the selected Node has a Main Editor, it's still not shown (the intended behaviour of the feature), but the sub-editors are shown, this correctly opens the AnimationPlayerEditor plugin and other sub-plugins.

Fixes and closes godotengine#63621.
@alfredbaudisch
Copy link
Contributor

This bug also applies to the MultiplayerSynchronizer / Replication tab.

https://streamable.com/3kamgu

I believe this is a bug, because you can get in a state where you have one MultiplayerSynchronizer node selected but it's actually editing a different node.

https://streamable.com/v2edvp

@danhealy this is also fixed by #63813

akien-mga pushed a commit that referenced this issue Aug 3, 2022
@alfredbaudisch @akien-mga
Display sub-plugins when Stay in Script Editor is On
c574f71 
Currently, with stay_in_script_editor_on_node_selected as On, inspector_only is forcibly set, and no editors from the node selected are displayed.

With this change, if the selected Node has a Main Editor, it's still not shown (the intended behaviour of the feature), but the sub-editors are shown, this correctly opens the AnimationPlayerEditor plugin and other sub-plugins.

Fixes and closes #63621.

(cherry picked from commit eaaedb2)
@jgillich jgillich mentioned this issue Aug 4, 2022
Closed
@akien-mga akien-mga mentioned this issue Aug 4, 2022
Closed
Riordan-DC pushed a commit to Riordan-DC/godot that referenced this issue Jan 24, 2023
@alfredbaudisch
Display sub-plugins when Stay in Script Editor is On
5b67f9c 
Currently, with stay_in_script_editor_on_node_selected as On, inspector_only is forcibly set, and no editors from the node selected are displayed.

With this change, if the selected Node has a Main Editor, it's still not shown (the intended behaviour of the feature), but the sub-editors are shown, this correctly opens the AnimationPlayerEditor plugin and other sub-plugins.

Fixes and closes godotengine#63621.

(cherry picked from commit eaaedb2)
@RokeJulianLockhart
Copy link

Screenshot_20230929_110355 Screenshot_20230929_110406

Am I having the same issue? They seemed to stop loading altogether after I once tried loading the animations from the scripts pane.

@RokeJulianLockhart
Copy link

I think I am having the same issue now – switching once to the AnimationPlayer node fixed it. All I had to do was switch to it once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression topic:animation topic:editor
Projects
4.x Priority Issues
Archived in project
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Display sub-plugins when Stay in Script Editor is On alfredbaudisch/godot
6 participants
@danhealy @Calinou @alfredbaudisch @gravit22 @RokeJulianLockhart @tefusion