Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange behavior with ul/ol tags in RichTextLabel #61621

Open
Rindbee opened this issue Jun 2, 2022 · 3 comments
Open

Strange behavior with ul/ol tags in RichTextLabel #61621

Rindbee opened this issue Jun 2, 2022 · 3 comments
Labels
bug topic:gui
Milestone
4.x

Comments

@Rindbee
Copy link
Contributor

Rindbee commented Jun 2, 2022 •
edited
Loading

Godot version

v4.0.alpha6.official [e4f0fc5] v4.0.alpha.custom_build [6cd730e]

System information

Linux Mint 20.3, Vulkan, NVIDIA GeForce GTX 1050 Ti

Issue description

  1. Strange behavior near ul/ol close tags;
  2. Strange behavior with empty ul/ol tags;
  3. Strange behavior with nested ul/ol tags.

The first 2 points, they might be essentially the same one. Seems to be related to close tags.

1 captrue

Steps to reproduce

  1. Add a RichTextLabel
  2. Check Bbcode Enable
  3. Resize it to make it big enough
  4. In the Text field, enter the following text.
[ol]
two
three[ul]a
b
c[/ul]four
[/ol]end
test 1
a
[ul][/ul]b
c
a
[ol][/ol]b
c

Minimal reproduction project

No response
@Calinou
Copy link
Member

Calinou commented Jun 2, 2022

Do these issues occur on 3.4.4/3.5rc2?

@kleonc
Copy link
Member

kleonc commented Jun 2, 2022 •
edited
Loading

Do these issues occur on 3.4.4/3.5rc2?

No, as list tags (ul, ol) are not supported in 3.x, see #49914.

To precise this is the result in 3.5.rc3:
Godot_v3 5-rc3_win64_VSdO9S6B13

@Calinou Calinou added this to the 4.0 milestone Jun 2, 2022
Rindbee added a commit to Rindbee/godot that referenced this issue Jun 4, 2022
@Rindbee
Fix strange behavior with list close tags and empty list tags
a14f7c4 
Fix the first two points in godotengine#61621.

Support for two  writing ways: compact or loose. The loose one is designed for easy editing in the editor.
For this, the first blank line (if exists) right after the list tags (`[ol]`, `[/ol]`, `[ul]`, and `[/ul]`)
will be ignored.

Make sure the empty list contains at least one item, that is, an empty list is ultimately a list with one item.
As a reminder here is a list.
@Rindbee Rindbee mentioned this issue Jun 4, 2022
Merged
@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Jan 19, 2023
@YuriSizov
Copy link
Contributor

For the reference, the first two points were resolved by the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.x
Development

No branches or pull requests
5 participants
@Calinou @Chaosus @kleonc @YuriSizov @Rindbee