Merge pull request #88598 from YeldhamDev/this_wasnt_even_my_bug!

Fix `RichTextLabel`'s tag stack being overridden on translation change
godotengine · Feb 20, 2024 · b8f106a · b8f106a
2 parents fb8f0da + aa258c6
commit b8f106a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/scene/gui/rich_text_label.cpp b/scene/gui/rich_text_label.cpp
@@ -5650,10 +5650,15 @@ void RichTextLabel::set_text(const String &p_bbcode) {
 }
 
 void RichTextLabel::_apply_translation() {
+	// If `text` is empty, it could mean that the tag stack is being used instead. Leave it be.
+	if (text.is_empty()) {
+		return;
+	}
+
 	String xl_text = atr(text);
 	if (use_bbcode) {
 		parse_bbcode(xl_text);
-	} else { // raw text
+	} else { // Raw text.
 		clear();
 		add_text(xl_text);
 	}