Skip to content

Commit

Permalink
Merge pull request #97198 from raulsntos/dotnet/open-visual-studio-wi…
Browse files Browse the repository at this point in the history
…th-dotnet-cli

C#: Use dotnet CLI to launch `OpenVisualStudio.dll`
  • Loading branch information
akien-mga committed Sep 20, 2024
2 parents 90a1192 + ec189b1 commit 2f078e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TargetFramework>net6.0-windows</TargetFramework>
<LangVersion>10</LangVersion>
<Nullable>enable</Nullable>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<SelfContained>False</SelfContained>
<RollForward>LatestMajor</RollForward>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,11 +259,12 @@ public Error OpenInExternalEditor(Script script, int line, int col)

var args = new List<string>
{
Path.Combine(GodotSharpDirs.DataEditorToolsDir, "GodotTools.OpenVisualStudio.dll"),
GodotSharpDirs.ProjectSlnPath,
line >= 0 ? $"{scriptPath};{line + 1};{col + 1}" : scriptPath
};

string command = Path.Combine(GodotSharpDirs.DataEditorToolsDir, "GodotTools.OpenVisualStudio.exe");
string command = DotNetFinder.FindDotNetExe() ?? "dotnet";

try
{
Expand Down

0 comments on commit 2f078e5

Please sign in to comment.