Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the load and quick load options first in the inspector's resource popup menu #7454

Open
mieldepoche opened this issue Aug 5, 2023 · 6 comments

Comments

@mieldepoche
Copy link

Describe the project you are working on

prototype

Describe the problem or limitation you are having in your project

image image image

As you can see, there is sometimes a big amount of options in those drop-downs before and even after the quick load option.
This can be a pain since:

  • the position is inconsistent (it can be last or not, meaning you have to first look for it)
  • it often ends up far from where the mouse is

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Put the quick load and load options at the begining of the list.

  • it creates a consistent experience accross all of the resource types: first option is always the same, and one you often want to use.
  • on setups with enough vertical space, and when the button in the inspector is high enough, it actually ends up really close to where the mouse is:
    image

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

image

image

If this enhancement will not be used often, can it be worked around with a few lines of script?

used often

Is there a reason why this should be core and not an add-on in the asset library?

can't be an addon afaik

@Calinou
Copy link
Member

Calinou commented Aug 6, 2023

I remember this being discussed a while ago, but I don't have the link to it anymore.

I generally think this is a good idea, but we should be careful it's a net usability upgrade overall. In some situations, having new resources on top may be more important. For example, for properties that accept Curve or Gradient resources, you won't save them to files that often, so having the New <resource type> button first is usually a better idea.

@Mickeon
Copy link

Mickeon commented Aug 9, 2023

I implemented this as actual code, in the unrelated process of testing the removal of "New" before every class name. With a lot of classes it looks like this (good luck reading):
image

@mieldepoche
Copy link
Author

this is still bothering me, and maybe the solution is moving load and unload at the top of the list, but also shift the list up: that way the relative position of the first element is preserved, but the loading operations are close to the cursor position too.

image

@Calinou
Copy link
Member

Calinou commented Mar 26, 2024

@Mickeon Do you have a branch with the code that correponds to the screenshot you took? It may be worth opening a PR 🙂

this is still bothering me, and maybe the solution is moving load and unload at the top of the list, but also shift the list up: that way the relative position of the first element is preserved, but the loading operations are close to the cursor position too.

I'm not sure if we have a way to control where the popup from an inspector dropdown appears when clicking. It might be feasible as inspector dropdowns aren't standard MenuButtons, but something custom.

@Disar
Copy link

Disar commented Oct 9, 2024

I remember this being discussed a while ago, but I don't have the link to it anymore.

I generally think this is a good idea, but we should be careful it's a net usability upgrade overall. In some situations, having new resources on top may be more important. For example, for properties that accept Curve or Gradient resources, you won't save them to files that often, so having the New button first is usually a better idea.

looking at the mockup adding load/quickload on top doesn't disrupt the order as much as it does now where we have to go all the way down for it. With the 2 on top you're still relatively close to the "new" resources.

But maybe I'm bias.

Alternatively if we could ctrl+click the asset property instead of right click showing us the quick load popup and ctrl+shift+click the load popup I'd be happy with that too

@Calinou
Copy link
Member

Calinou commented Oct 10, 2024

godotengine/godot#97860 addresses this proposal in a different way, by moving Quick Load outside the dropdown (and into a button that's separate from the dropdown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants