Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete C# methods from Using RigidBody2D #5957

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

jarommadsen
Copy link
Contributor

SetAppliedForce and SetAppliedTorque have been deprecated in favor of the AppliedForce and AppliedTorque setters but the Physics Introduction still referenced them in the C# code snippet.

`SetAppliedForce` and `SetAppliedTorque` have been deprecated in favor of the `AppliedForce` and `AppliedTorque` setters but the Physics Introduction still referenced them in the C# code snippet.
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit a7f7913 into godotengine:master Jul 29, 2022
@jarommadsen jarommadsen deleted the patch-1 branch July 29, 2022 19:41
@Calinou
Copy link
Member

Calinou commented Jul 29, 2022

Are you sure this applies to 3.4 and 3.5 as well? godotengine/godot-proposals#2184 wasn't implemented there as it breaks compatibility.

@jarommadsen
Copy link
Contributor Author

Are you sure this applies to 3.4 and 3.5 as well? godotengine/godot-proposals#2184 wasn't implemented there as it breaks compatibility.

Yes. I can do some digging to figure out when it happened but SetAppliedForce etc. are marked as deprecated in 3.4 and 3.5.

@jarommadsen
Copy link
Contributor Author

Unless @Calinou you're referring to the cherrypick labels @raulsntos added? This feedback originated while working on the latest stable version/docs.

@Calinou
Copy link
Member

Calinou commented Jul 29, 2022

I see, I'll cherry-pick this then.

Edit: Cherry-picked to the 3.5, 3.4 and stable branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants