Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing C++17 flag for Windows build in GDNative SConstruct #4709

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

bengtsts
Copy link
Contributor

@bengtsts bengtsts commented Mar 3, 2021

The SConstruct file doesn't appear to be in the master branch so this PR is for 3.2.

@bengtsts bengtsts marked this pull request as ready for review March 3, 2021 12:33
@bengtsts bengtsts closed this Mar 3, 2021
@bengtsts bengtsts reopened this Mar 3, 2021
@Calinou Calinou added the bug label Mar 3, 2021
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I applied the change to the master branch as well: 7321b5b

@Calinou Calinou changed the title Added missing C++ 17 flag for Windows compilation to match OSX and li… Add missing C++17 flag for Windows build in GDNative SConstruct Mar 3, 2021
@Calinou Calinou merged commit e2edc04 into godotengine:3.2 Mar 3, 2021
Calinou added a commit that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants