-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a menu for launching GoDot from visual studio #32
Conversation
I have some suggestions This Launch make it Godot cuz it is Godot not GoDot :) You can replace the debug button(the one that have C# text thingy) with your launch button with the Godot Engine icon Or place a Godot button next to the live share button cuz it is more efficient And btw what is the use of the configure button |
@Jiiks |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I hid some comments because this was turning too spammy and off-topic. Those things can be talked somewhere else. I'll give this a review tonight. The commands solutions is one I was not fond of, but since the plugin hasn't been working for a long time, we may as well accept it's the only option for now. |
Great, keep the iteration AND community interest and support moving forwards! |
That PR only seems to cherry-pick commits from this and another PR. I don't understand why. |
I think the person who submitted PR (35) has a strong enthusiasm for the UI aspect of Godot Visual Studio Extension. I hope the community encourages him to continue the UI iteration (at least). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks: GoDot
should be changed to Godot
. Also, we probably want a more specific id than MyMenuGroup
.
Other than that, the changes look good. I'll wait some days in case OP wants to address the nitpicks, otherwise I'll merge.
Btw make these so we can launch the game better cuz some of the feature is weird like why not make the button on tool bar and more stuff |
@PandoCyclone Do keep up with your enthusiasm. I am gathering all the necessary overview and feedback. Keep it UP! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@GeorgeS2019 Please, don't have these discussions here. None of that seems relevant to this PR, so it feels like spam. |
Thanks for the contribution! If anyone wants to further improve this or fix typos, feels free to open a PR. |
No description provided.