Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android NDK version >= 23 requires nightly toolchain #95

Closed
necrashter opened this issue Mar 4, 2023 · 1 comment · Fixed by #96
Closed

Android NDK version >= 23 requires nightly toolchain #95

necrashter opened this issue Mar 4, 2023 · 1 comment · Fixed by #96
Labels
error There is an error in the book in some way

Comments

@necrashter
Copy link
Contributor

libgcc was removed in Android NDK version r23-beta3 and Rust was updated accordingly (see this issue). However, this change does not seem to be available in stable Rust yet (2023-03-04). This is should be mentioned in exporting for Android section.

I will make a PR for this but I'm not sure where we should mention it. My idea is to add a "Troubleshooting" section similar to "Errors you might encounter" in HTML5 export page. But I think it should be included at the start as well since users start following instructions before reading the troubleshooting.

@necrashter necrashter added the error There is an error in the book in some way label Mar 4, 2023
@chitoyuu
Copy link
Contributor

chitoyuu commented Mar 4, 2023

Thanks for the initiative!

But I think it should be included at the start as well since users start following instructions before reading the troubleshooting.

Very good point. I would perhaps do it as a blockquote "alert" like the "bit of context" one, right at the top, given how likely a user might run into this problem on the first attempt.

As this is expected to be a temporary issue, it would be good to note the time of writing and include a link to the upstream issue for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error There is an error in the book in some way
Projects
None yet
2 participants