More reliable macOS hot-reloading test, workaround missing GDExtension methods #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UDP handling on Python is too low-level with the standard library, and turned out to work unreliably across platforms (especially macOS). Even with separate select/poll implementations, I couldn't get it to work 100%.
…re selective Reverts commit c9e6fd6.
Bromeon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS hot reloading test has been flaky, with the UDP communication failing around 10-20% of the time. Python's low-level
select()API is not easy to use reliably -- it often returned immediately, indicating a timeout. After spending a lot of time on different approaches (e.g.poll(), retrying, etc) to no avail, I decided to rewrite the orchestration script to GDScript and run it in the Godot runtime. This also brings parity to the other side (Editor instance doing the reload).This reduces the active Python code in the repo again to 0. We had a good run... 🥲
Apart from that, the PR works around 8 GDExtension methods that are advertised in the API but missing at runtime, see godotengine/godot#90303 for details.
Also includes smaller maintenance changes, see commits.