Fix ResourceImporter* methods not found in Release mode; add Release CI
#537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
force-pushed
the
bugfix/missing-release-methods
branch
from
5fd22af
to
e82cc1f
Compare
Bromeon
changed the title
ResourceImporterOgg* methods not found in Release mode; add Release CI
Bromeon
added
bug
c: register
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-537 |
Bromeon
changed the title
ResourceImporterOgg* methods not found in Release mode; add Release CIResourceImporter* methods not found in Release mode; add Release CI
…is in Release mode
Bromeon
force-pushed
the
bugfix/missing-release-methods
branch
from
e82cc1f
to
a1a4418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489. Corresponding upstream fix: godotengine/godot#86209.
I still worked around the problem in gdext, as it is present in already-released Godot 4.2.0 and 4.2.1.
Adds a full-ci job to run integration tests with a release Godot version. This necessitated some changes in our nightly pipeline.
The new release CI also revealed another upstream issue: godotengine/godot#86264. In short, dynamic calls like
Object::callorVariant::callare unchecked in Release mode. Integration tests relying on those checks have thus been disabled in Release builds.