Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Redis SSL connection via redis.ParseURL #815

Closed
iwpnd opened this issue Nov 23, 2021 · 5 comments
Closed

[Feature Request]: Redis SSL connection via redis.ParseURL #815

iwpnd opened this issue Nov 23, 2021 · 5 comments

Comments

@iwpnd
Copy link
Member

iwpnd commented Nov 23, 2021

Hi 👋

Tegola does not yet support redis SSL connections and I'd like to change that, or request this feature.
e.g.: redis://:password@host

For this to work I'd like to add another option to [cache] called uri or url. If this option is set, I'd change this to use ParseURL to create redis.Options instead of creating the config manually.
ParseURL attaches the TLSConfig to the redis.Options if rediss:// is part of the connection url. That way both options stay viable and tegola is a feature richer. 😁

What do you think?

@ARolek
Copy link
Member

ARolek commented Nov 23, 2021

@iwpnd I just looked at the redis config and it does appear to support a password attribute. Is this request more around using ParseURL instead of breaking up the attributes into separate key-value pairs or is SSL not currently supported?

@iwpnd
Copy link
Member Author

iwpnd commented Nov 23, 2021

Hey, SSL is currently not supported. There are several ways to enable it. ParseURL is just one of them. Another would be as add a TLSConfig to redis.Options upon receiving something like ssl=true in the cache option. Either is fine and solves the problem.

@ARolek
Copy link
Member

ARolek commented Nov 24, 2021

@iwpnd I would say we start with enhancing the current implementation by supporting an ssl config option as a boolean. I do like the idea of adding a url or uri property (I want to do this for the PostGIS provider too). Is this something you want to tackle and send in a PR for? I'm happy to help with it.

@iwpnd
Copy link
Member Author

iwpnd commented Nov 24, 2021

Happy to do it. :)

@ARolek
Copy link
Member

ARolek commented Nov 30, 2021

closed via bdce754. Thanks for the contribution!

@ARolek ARolek closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants