Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: Fix __mul__ of list and tuple on negative case #67

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

corona10
Copy link
Collaborator

py: Fix mul of list and tuple on negative case

@codecov-io
Copy link

Codecov Report

Merging #67 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   68.45%   68.61%   +0.16%     
==========================================
  Files          59       59              
  Lines       10495    10499       +4     
==========================================
+ Hits         7184     7204      +20     
+ Misses       2804     2788      -16     
  Partials      507      507
Impacted Files Coverage Δ
py/tuple.go 39.81% <100%> (+8.68%) ⬆️
py/list.go 35.13% <100%> (+5.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b8c68...b4d99f5. Read the comment docs.

@corona10
Copy link
Collaborator Author

@ncw PTAL

@corona10 corona10 requested a review from ncw July 27, 2019 13:46
Copy link
Collaborator

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great please merge 😀

@corona10 corona10 merged commit bd0985b into go-python:master Jul 28, 2019
@corona10 corona10 deleted the fix_mul branch July 28, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants