Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw file view tweaks #15520

Merged
merged 6 commits into from
Apr 22, 2021
Merged

Raw file view tweaks #15520

merged 6 commits into from
Apr 22, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 16, 2021

  • Limit SVG images to 600px width
  • Adjust size of view toggle buttons to match other buttons
  • Fix border-right on active rendered view toggle button
  • Add border on image
  • Make Edit/Delete buttons easier to click

Had to create a separate CSS file because the less parser can not parse CSS4 case-insensitive attribute selectors which are widely supported by browsers.

Fixes: #15515
Ref: less/less.js#3027

Before (with huge image):

Screen Shot 2021-04-16 at 20 34 17

After:
Screen Shot 2021-04-16 at 20 57 38

@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Apr 16, 2021
@silverwind
Copy link
Member Author

BTW I would like to drop Less because it's a dead project and go for either plain CSS or SCSS but stuff like this will make it hard to convert to SCSS.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2021
- Limit SVG images to 600px width
- Adjust size of view toggle buttons to match other buttons
- Make Edit/Delete buttons easier to click

Had to create a separate CSS file because the less parser can not parse
CSS4 case-insensitive attribute selectors which are widely supported by
browsers.

Fixes: go-gitea#15515
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2021
@lunny lunny added this to the 1.15.0 milestone Apr 21, 2021
@silverwind silverwind mentioned this pull request Apr 21, 2021
@6543
Copy link
Member

6543 commented Apr 22, 2021

🚀

@6543 6543 merged commit 834fc74 into go-gitea:master Apr 22, 2021
@silverwind silverwind deleted the svgview branch April 22, 2021 21:48
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display SVG respecting viewbox
6 participants