Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Delete Branch confirmation modal from merged pull requests #31503

Open
silverwind opened this issue Jun 26, 2024 · 2 comments
Open

Remove the Delete Branch confirmation modal from merged pull requests #31503

silverwind opened this issue Jun 26, 2024 · 2 comments
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@silverwind
Copy link
Member

Feature Description

I find this modal annoying and it does not match GitHub behaviour where a merged PR branch is deleted in a single click. I think it's always safe to delete such branches, right?

Screenshots

image
@silverwind silverwind added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jun 26, 2024
@silverwind silverwind changed the title Remove the Delete Branch modal from merged pull requests Remove the Delete Branch confirmation modal from merged pull requests Jun 26, 2024
@delvh
Copy link
Member

delvh commented Jun 26, 2024

I think it's always safe to delete such branches, right?

If this branch is fully contained within the main branch, yes.
However, git can't know this when you squash merge or rebase merge.

@delvh
Copy link
Member

delvh commented Jun 26, 2024

But yeah, branches that have no commit ahead of them should be deleteable without a modal

@delvh delvh added proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @delvh