Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Preview Changes #31157

Closed
TimerWolf opened this issue May 29, 2024 · 2 comments · Fixed by #31158
Closed

[Bug] Preview Changes #31157

TimerWolf opened this issue May 29, 2024 · 2 comments · Fixed by #31158
Assignees
@wxiaoguang
Labels
type/bug
Milestone
1.23.0

Comments

@TimerWolf
Copy link

TimerWolf commented May 29, 2024 •
edited
Loading

Description

I have not test this a lot but it seems like "files" only created within gitea says "not found" when you try to use the "preview changes" tab, files that has a "local repo" as well works without any problems

I can't reproduce the bug, on demo site, but it worked fine in "1.21.11"

Gitea Version

1.22.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/TimerWolf/16025f3b31158a59e86885050cabda51

Screenshots

Gitea

Git Version

2.34.1

Operating System

Ubuntu 22.04.3 (LTS)

How are you running Gitea?

I download the version from github, i use the "gitea-1.22.0-linux-amd64" binary

Database

MySQL/MariaDB
@wxiaoguang
Copy link
Contributor

It's related to a recent permission check. Will propose a fix soon.

@wxiaoguang wxiaoguang self-assigned this May 29, 2024
@wxiaoguang wxiaoguang mentioned this issue May 29, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Fix markup preview #31158

@yp05327 yp05327 added this to the 1.23.0 milestone May 29, 2024
lunny pushed a commit that referenced this issue May 29, 2024
@wxiaoguang
Fix markup preview (#31158)
34daee6 
Fix #31157

After:

![image](https://github.com/go-gitea/gitea/assets/2114189/4d918cce-cd0d-4601-9c81-4b32df1b0b38)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 29, 2024
@wxiaoguang @GiteaBot
Fix markup preview (go-gitea#31158)
1d01d88 
Fix go-gitea#31157

After:

![image](https://github.com/go-gitea/gitea/assets/2114189/4d918cce-cd0d-4601-9c81-4b32df1b0b38)
@GiteaBot GiteaBot mentioned this issue May 29, 2024
Merged
silverwind pushed a commit that referenced this issue May 30, 2024
@GiteaBot @wxiaoguang
Fix markup preview (#31158) (#31166)
fb14ca3 
Backport #31158 by @wxiaoguang

Fix #31157

After:


![image](https://github.com/go-gitea/gitea/assets/2114189/4d918cce-cd0d-4601-9c81-4b32df1b0b38)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wxiaoguang wxiaoguang

Labels
type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

Fix markup preview wxiaoguang/gitea
3 participants
@wxiaoguang @TimerWolf @yp05327