Reorder the process of repo rename.

[FlyingOnion]

Feature Description

I'm facing a small problem when I implement my own notifier. When I implement NotifyRenameRepository function, I could not find the new repo name (the name in arg repo *models.Repository is the old name). After I check the code I found that repo.Name = newRepoName is called after function repo_service.ChangeRepositoryName.

There are two places:

gitea/routers/web/repo/setting.go

Line 103 in f58e687

if err := repo_service.ChangeRepositoryName(ctx.User, repo, newRepoName); err != nil {

gitea/routers/api/v1/repo/repo.go

Line 651 in f58e687

if err := repo_service.ChangeRepositoryName(ctx.User, repo, newRepoName); err != nil {

Wait for your opinion.

Screenshots

No response

[lunny]

I think you can find the old and new name. NotifyRenameRepository(doer *user_model.User, repo *repo_model.Repository, oldRepoName string).

[FlyingOnion]

In NotifyRenameRepository(doer *user_model.User, repo *repo_model.Repository, oldRepoName string), repo.Name returns old name. repo.Name is updated after func repo_service.ChangeRepositoryName(doer *models.User, repo *models.Repository, newRepoName string) error function returns.

This is a brief order in routers/api/v1/repo/repo.go function updateBasicProperties, so as in routers/web/repo/setting.go function SettingsPost.

func updateBasicProperties(ctx *context.APIContext, opts api.EditRepoOption) error {
  repo := ctx.Repo.Repository
  newRepoName := repo.Name
  if opts.Name != nil {
    newRepoName = *opts.Name
  }
  repo_service.ChangeRepositoryName(ctx.User, repo, newRepoName) {
    models.ChangeRepositoryName(doer, repo, newRepoName) // does not update repo.Name in this function call
    notification.NotifyRenameRepository(doer, repo, oldRepoName) // repo.Name remains unchanged
  }
  repo.Name = newName // repo.Name is updated here
}

[lunny]

Ah, then I think it's a bug rather a feature.