Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u2f-api script should be moved to npm/webpack #17712

Closed
silverwind opened this issue Nov 18, 2021 · 5 comments
Closed

u2f-api script should be moved to npm/webpack #17712

silverwind opened this issue Nov 18, 2021 · 5 comments

Comments

@silverwind
Copy link
Member

silverwind commented Nov 18, 2021

Feature Description

There is a unversioned copy of what I think is a minified version of u2f-api that came in #3971. It should be moved to npm/webpack to become maintainable.

Maybe @jonasfranz can point out the source/version of this script.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 18, 2021

I believe the code comes from https://github.com/github/u2f-api/blob/master/u2f-api-polyfill.js and its fork like https://github.com/grantila/u2f-api

Some fingerprints:

"U2F isn't supported over http, only https"
"U2F not supported"
ensureSupport
isSupported
formatRegisterRequest_

And most u2f-api we can find in npm they are all copied and modified from the same origin, they share same API interfaces, like:

@wxiaoguang
Copy link
Contributor

As reported in

Maybe we should refactor this module too.

@silverwind
Copy link
Member Author

I think it needs to be changed to use webauthn, see #6892.

@lunny
Copy link
Member

lunny commented Nov 22, 2021

@silverwind So maybe we could close this one and just continue in #6892, we could remove u2f-api and introduce webauthn in the same PR.

@silverwind
Copy link
Member Author

Yes, u2f removal can come with the webauthn addition.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants