Skip to content

Commit

Permalink
Don't install playwright twice (#29302)
Browse files Browse the repository at this point in the history
1. `playwright/test` is already installed as part of `deps-frontend` on
CI which runs before, so it's better to not install it again (on a
potentially different version), and just use the version from
package.json and add the `deps-frontend` dependency.
2. `PLAYWRIGHT_DIR` is a undefined variable, so I removed it

```bash
$ git show c8ded77 | grep PLAYWRIGHT_DIR
+playwright: $(PLAYWRIGHT_DIR)
```
  • Loading branch information
silverwind authored Feb 22, 2024
1 parent 2bd999a commit c236e64
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,7 @@ test-mssql\#%: integrations.mssql.test generate-ini-mssql
test-mssql-migration: migrations.mssql.test migrations.individual.mssql.test

.PHONY: playwright
playwright: $(PLAYWRIGHT_DIR)
npm install --no-save @playwright/test
playwright: deps-frontend
npx playwright install $(PLAYWRIGHT_FLAGS)

.PHONY: test-e2e%
Expand Down

0 comments on commit c236e64

Please sign in to comment.