Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetectorCascade is awkward to initialize #66

Open
danielvarga opened this issue Jun 14, 2017 · 0 comments
Open

DetectorCascade is awkward to initialize #66

danielvarga opened this issue Jun 14, 2017 · 0 comments

Comments

@danielvarga
Copy link

DetectorCascade.imageWidth/imgHeight/imgWidthStep initialization has to happen before DetectorCascade::init() calls, through writing into public members. Turning them into init() arguments would be cleaner software design IMHO. But what really made my missing initialization hard to spot was that this line was commented out:

https://github.com/gnebehay/OpenTLD/blob/master/src/libopentld/tld/DetectorCascade.cpp#L85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant