Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better surface which ports are currently active #248

Closed
1 of 4 tasks
jankeromnes opened this issue Jan 17, 2019 · 6 comments
Closed
1 of 4 tasks

Better surface which ports are currently active #248

jankeromnes opened this issue Jan 17, 2019 · 6 comments
Assignees

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Jan 17, 2019

When you start a web server on a given port, you'll see a notification appear that either offers to Expose the port, or to open it in a Preview pane or Browser tab.

However, sometimes the notification gets dismissed too early (for example, if you reload the page, or sometimes when another port is also opened around the same time). And if you "lose" such a notification, it's not obvious how to find your running apps again.

Here are a few ideas (most of them are from @paulmelnikow -- many thanks!):

  • We could re-surface the open port notifications when the window is reopened (except when the Preview is already open)
  • Also, we probably shouldn't dismiss a port notification just because another port was opened (I think that's a bug)
  • We could show which ports are active somewhere in the menus, providing another way to open previews (EDIT: it's in the bottom status bar, although not very obvious)
  • We could implement a --all option for gp url (see [cli] Implement a gp command to get preview URLs #246 (comment))
@svenefftinge
Copy link
Member

We could show which ports are active somewhere in the menus, providing another way to open previews

We show that in the status bar. clicking on the item will open the ports view with more information and commands. Doesn't seem to be obvious though if you have missed that.

@paulmelnikow
Copy link

We show that in the status bar. clicking on the item will open the ports view with more information and commands. Doesn't seem to be obvious though if you have missed that.

Oh nice! I see that now, and I think even saw it before but did not realize it was clickable. Maybe the dot on the status bar could be rendered in green instead of white; that would make it seem more clickable. Also I'd suggest changing the label, both in the status bar and the View menu, from Ports to Open Ports.

A small thing, though if I missed it surely others will too!

@svenefftinge
Copy link
Member

svenefftinge commented Mar 25, 2019

Just got that question again.
I think it would be good to have the ports view added to the bottom panel.

@AlexTugarev
Copy link
Member

I think it would be good to have the ports view added to the bottom panel.

That's already the case.

@AlexTugarev
Copy link
Member

Also I'd suggest changing the label, both in the status bar and the View menu, from Ports to Open Ports.

✔️

@AlexTugarev
Copy link
Member

This issue looks outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants