Support ssh gateway when connecting from workspace explorer #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Jul 24, 2023
|
|
||
| let sshDest: SSHDestination; | ||
| let password: string | undefined; | ||
| if (await this.experimentsService.getUseLocalSSHProxy()) { |
There was a problem hiding this comment.
Should not be here a check that local ssh is initialized? i.e the logic should be similar to open URI.
There was a problem hiding this comment.
I see it is initialised above. I find it is quite confusing with so many paths. I think there should be only one function which hides the entires connectivity logic, i.e. we should not call initializeLocalSSH here and there, but only this function can. This function accepts the connection params as well as modes of opening a window, e.g. which folder and current or not, etc. All other clients start the workspace and then call to this function. It does not need to be the part of this PR, but would be nice to clean up.
akosyakov
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support ssh gateway when connecting from workspace explorer
How to test