Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process errors from supervisor grpc-web lib #84

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Conversation

mustard-mh
Copy link
Contributor

Description

Try to convert ServiceError into readable error code

Related Issue(s)

Fixes https://gitpod.slack.com/archives/C045J13P8A1/p1689083942010629?thread_ts=1688971512.520299&cid=C045J13P8A1

How to test

Documentation

/hold

@mustard-mh
Copy link
Contributor Author

Tested locally
image

@mustard-mh mustard-mh merged commit 3649e17 into master Jul 11, 2023
1 check passed
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Jul 11, 2023

My changes not pushed because of my network 🤯 cc @jeanp413 in case you want to clean it up, I will push again

Seems pushed

@jeanp413 jeanp413 deleted the hw/readble-error branch July 11, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant