Better error message for url exception

gitpod-io · Oct 13, 2023 · 2c9887a · 2c9887a
1 parent 7c452c8
commit 2c9887a
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/common/telemetry.ts b/src/common/telemetry.ts
@@ -64,9 +64,13 @@ export function createSegmentAnalyticsClient(settings: AnalyticsSettings, gitpod
 }
 
 
-export function getErrorMetricsEndpoint(gitpodHost: string): string {
-	const serviceUrl = new URL(gitpodHost);
-	return `https://ide.${serviceUrl.hostname}/metrics-api/reportError`;
+function getErrorMetricsEndpoint(gitpodHost: string): string {
+	try {
+		const serviceUrl = new URL(gitpodHost);
+		return `https://ide.${serviceUrl.hostname}/metrics-api/reportError`;
+	} catch {
+		throw new Error(`Invalid URL: ${gitpodHost}`);
+	}
 }
 
 export async function commonSendEventData(logService: ILogService, segmentClient: Analytics | undefined, machineId: string, eventName: string, data?: any): Promise<void> {