Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Filter Out CI User Responses from Time to First Response #65

Closed
philnielsen opened this issue Jul 21, 2023 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@philnielsen
Copy link

philnielsen commented Jul 21, 2023

Hi! Awesome tool, I could definitely see us using it.

One thing that makes it sort of hard to use (at least for our org at the moment, which is why I thought the metrics were wrong in that other issue :) ) is that we have CI users that respond to PRs. This messes with the time to response calculations as they are always pretty quick to respond, and thus beat the human response most of the time. I've tested by removing the first_comment_time from this line and re-running to get the actual time to first response (at least for us, assuming that a review comment is the first response is an ok assumption, I understand that isn't always true for everyone that would use this tool.)

My proposed solution would be to add a list of Users to ignore comments from, but I'm not really a Python person and can't tell how easy that would be to implement, since it looks like now you just pull the first comment from each issue, pr or discussion.

@zkoppert zkoppert added the enhancement New feature or request label Jul 21, 2023
@zkoppert
Copy link
Member

zkoppert commented Jul 21, 2023

That proposed solution sounds feasible to me! I will put this on the todo list. Thanks for the suggestion @philnielsen!

@Okabe-Junya
Copy link
Contributor

Thank you for the excellent CI workflow and thoughtful proposals!!

I have submitted a patch that resolves this issue, excluding certain users from the first response calculation. #78

I hope this patch will be accepted and merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants