Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set contentType for database uploads #887

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Set contentType for database uploads #887

merged 4 commits into from
Jan 25, 2022

Conversation

rneatherway
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@rneatherway rneatherway requested a review from a team as a code owner January 24, 2022 15:55
rneatherway
rneatherway commented Jan 24, 2022
View reviewed changes
src/database-upload.ts Outdated
@@ -63,6 +63,7 @@ export async function uploadDatabases(
data: payload,
headers: {
authorization: `token ${apiDetails.auth}`,
contentType: "application/zip",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% confident about the format of this line, so I'll test it using this branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

aeisenberg
aeisenberg approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if this passes all of your tests.

src/database-upload.ts Outdated
@@ -63,6 +63,7 @@ export async function uploadDatabases(
data: payload,
headers: {
authorization: `token ${apiDetails.auth}`,
contentType: "application/zip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

Base automatically changed from rneatherway/remove-old-upload-path to main January 25, 2022 14:08
@rneatherway
Copy link
Contributor Author

Using the string literal as a header key worked 👍

@rneatherway rneatherway merged commit 5e23536 into main Jan 25, 2022
@rneatherway rneatherway deleted the rneatherway/content-type branch January 25, 2022 18:40
@github-actions github-actions bot mentioned this pull request Jan 31, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rneatherway @aeisenberg