Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR check job for Ruby beta #685

Merged

Conversation

adityasharad
Copy link
Contributor

@adityasharad adityasharad commented Aug 5, 2021

Add a separate job that analyses the multilanguage test repo's Ruby code.
For now, run this only with the latest released build of CodeQL pointed to in defaults.json.
The nightly build and the cached builds don't support Ruby yet.

In future, we can update this and other PR checks to test a wider range of cases.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Copy link
Contributor

@hmakholm hmakholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK if tests pass after retargeting to hmakhoklm/pr/2.5.9

Add a separate job that analyses the multilanguage test repo's Ruby code.
For now, run this only with the latest released CodeQL build from defaults.json.
The cached builds and nightly builds don't support Ruby yet.

In future, we can update this and other PR checks to test a wider range of cases.
@adityasharad adityasharad changed the base branch from main to hmakholm/pr/2.5.9 August 9, 2021 15:42
@adityasharad adityasharad marked this pull request as ready for review August 9, 2021 15:43
@adityasharad adityasharad requested a review from a team as a code owner August 9, 2021 15:43
@adityasharad adityasharad merged commit bef7eec into github:hmakholm/pr/2.5.9 Aug 9, 2021
@github-actions github-actions bot mentioned this pull request Aug 9, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants