Add new packs input to init action
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This input allows users to specify which packs to run. It works in unison with the packs block of the config file and it is similar to how `queries` works. They both use `+` in the same way. Note that the `#TODO` in the pr check is still around, but the CLI is available. I will remove the TODO in the next commit.
aeisenberg
force-pushed
the
aeisenberg/pack-in-inputs
branch
from
108ced1
to
6e577cf
Compare
src/config-utils.ts
Outdated
| if (packsInput.startsWith("+")) { | ||
| packsInput = packsInput.substring(1).trim(); | ||
| if (!packsInput) { | ||
| throw new Error("Remove the '+' from the packs input."); |
There was a problem hiding this comment.
This could be a little more informative, e.g. A + was used in the packs input to specify that you wished to add some packs to your CodeQL analysis. However, no packs were specified. Please either remove the + or specify some packs.
There was a problem hiding this comment.
@aeisenberg Think you missed this comment? Unless you disagree, in which case no need to address it 🙂
There was a problem hiding this comment.
Right. Missed this. Thanks for pointing it out.
edoardopirovano
approved these changes
Jun 24, 2021
.github/workflows/pr-checks.yml
Outdated
| - uses: ./../action/init | ||
| with: | ||
| config-file: ".github/codeql/codeql-config-packaging3.yml" | ||
| packs: dsp-testing/codeql-pack1@0.0.4 |
There was a problem hiding this comment.
I think you need a + here? Otherwise this LGTM now.
aeisenberg
force-pushed
the
aeisenberg/pack-in-inputs
branch
2 times, most recently
from
257ff39
to
76e2e21
Compare
|
Build is failing because the version of the cli it is grabbing from the toolcache is not yet new enough to support all of the packaging commands. |
Also, update the options and inputs documentation.
aeisenberg
force-pushed
the
aeisenberg/pack-in-inputs
branch
from
76e2e21
to
4087f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This input allows users to specify which packs to run. It works in
unison with the packs block of the config file and it is similar to
how
queriesworks. They both use+in the same way.Note that the
#TODOin the pr check is still around, but the CLIis available. I will remove the TODO in the next commit.
Merge / deployment checklist