Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into v1 #549

Merged
merged 37 commits into from
Jun 7, 2021
Merged

Merge main into v1 #549

merged 37 commits into from
Jun 7, 2021

Commits on Apr 3, 2021

  1. Fix wording in README

    okyanusoz authored Apr 3, 2021
    Configuration menu
    Copy the full SHA
    8a1d7c2 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Configuration menu
    Copy the full SHA
    e94d93a View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Configuration menu
    Copy the full SHA
    d9a17ba View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Merge pull request #438 from okyanusoz/patch-1

    Fix wording in README
    aeisenberg authored May 31, 2021
    Configuration menu
    Copy the full SHA
    fad7cc4 View commit details
    Browse the repository at this point in the history
  2. Send the version and mode with the user agent

    This commit changes the way the action determines if running in action
    or runner mode. There is now an environment variable that is set at the
    beginning of the process and elsewhere in the process, we can check to
    see if the variable is set.
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    4758879 View commit details
    Browse the repository at this point in the history
  3. Use the version from package.json in the runner

    Update the ql queries to account for change in how we look for runner
    
    Previously, we guarded blocks of code to be run by the runner or the
    action using if statements like this:
    
    ```js
    if (mode === "actions") ...
    ```
    
    We are no longer doing this. And now, the `unguarded-action-lib.ql`
    query is out of date. This query checks that runner code does not
    unintentionally access actions-only methods in the libraries.
    
    With these changes, we now ensure that code scanning is happy.
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    4164096 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a4cdd3 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #516 from github/aeisenberg/user-agent

    Send version and mode to code scanning via user agent
    aeisenberg authored May 31, 2021
    Configuration menu
    Copy the full SHA
    ca94508 View commit details
    Browse the repository at this point in the history
  6. Fix the mergeback workflow

    We need to tag and mergeback if the tag does _not_ already exist.
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    981b5cb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7d701d2 View commit details
    Browse the repository at this point in the history
  8. Manually update the CHANGELOG

    This should have happened in a mergeback PR, but the workflow to
    generate this was broken.
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    a94829c View commit details
    Browse the repository at this point in the history
  9. Fix EOF newlines after npm version patch

    The removeNPMAbsolutePaths check requires no newlines at the
    end of the file. This ensures that the version update mimics
    the behavior.
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    c02d8cc View commit details
    Browse the repository at this point in the history
  10. 1.0.1

    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    f0e82b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Merge pull request #534 from github/aeisenberg/mergeback-fix

    Fix the mergeback workflow
    aeisenberg authored Jun 1, 2021
    Configuration menu
    Copy the full SHA
    4b4a5ee View commit details
    Browse the repository at this point in the history
  2. Use commander preAction hook for setMode

    Hooks are new to commander v8. We can use hooks to ensure that `setMode`
    is called before every command is invoked.
    aeisenberg committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    539d968 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Configuration menu
    Copy the full SHA
    2fee124 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #536 from github/aeisenberg/commander

    Use commander preAction hook for setMode
    aeisenberg authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    1d05ad7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    739e14d View commit details
    Browse the repository at this point in the history
  4. Add some dependencies for uploading artifacts

    Edoardo Pirovano authored and edoardopirovano committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    0cbd4b5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e8486b0 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #541 from github/update-supported-enterprise-serve…

    …r-versions
    
    Update supported GitHub Enterprise Server versions.
    aeisenberg authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4ac9009 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    61b5618 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #542 from github/robertbrignull/import-actions-lib

    Update unguarded-action-lib.ql to catch uses of actions-util.ts
    adityasharad authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    1ec2fd7 View commit details
    Browse the repository at this point in the history
  9. Add environment variables to signal feature and version to the CLI

    This PR ensures environment variables are set before any invocation of
    the CLI.  Here is a list of vars that are set:
    
    github/codeql-core#1124 (comment)
    
    This ensures the CLI knows the features and versions of the containing
    actions/runner.
    
    Additionally:
    
    - Fix the user agent so that it more closely aligns with user agent
      spec
    - Refactor environment variable initialization so that it all happens in
      one place and call.
    - Move Mode, getRequiredEnvParam, setMode, getMode out of actions-util
      and into util. actions-util is meant for utils only called by the
      action, not the runner.
    
    The `prepareLocalRunEnvironment()` method is most likely deprecated and
    should be removed. I originally added it because I had a way of working
    where I would run the action from my local machine to test out changes,
    but this was always a little flaky. So, I no longer use this way of
    working. I will probably remove it soon.
    aeisenberg committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    3708898 View commit details
    Browse the repository at this point in the history
  10. Remove local environment running

    This is a functionality that never worked perfectly and hasn't been
    used for a while.
    
    This allows developers to run the action on their local machine, but
    the run was always flaky and never 100% mirrored what was happening on
    the actions runner.
    aeisenberg committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    2c2ebdc View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    082575f View commit details
    Browse the repository at this point in the history
  12. Fix Unguarded actions library use code scanning error

    Must access the env var directly in order to avoid recursive calls to 
    `getRequiredEnvParam`.
    aeisenberg committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    cc0733f View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Cleaning up comments around env vars

    Also, move `getTemporaryDirectory` back to `actions-util`.
    aeisenberg committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f60ef17 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #539 from github/aeisenberg/env-vars

    Add environment variables to signal feature and version to the CLI
    aeisenberg authored Jun 3, 2021
    Configuration menu
    Copy the full SHA
    cbdf0df View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Add back retrying.

    chrisgavin committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    41dff7f View commit details
    Browse the repository at this point in the history
  2. Cleanup CodeQL DBs and output their location for later steps

    Edoardo Pirovano authored and edoardopirovano committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    ddb83a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. Configuration menu
    Copy the full SHA
    1644ade View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Fix stub in tests.

    chrisgavin committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f8c65b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48efe6e View commit details
    Browse the repository at this point in the history
  3. Merge pull request #547 from github/retrying-fix

    Add back retrying.
    chrisgavin authored Jun 7, 2021
    Configuration menu
    Copy the full SHA
    242fd82 View commit details
    Browse the repository at this point in the history
  4. 1.0.1

    github-actions[bot] committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    68d7c5f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    511fe43 View commit details
    Browse the repository at this point in the history