Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send version and mode to code scanning via user agent #516

Merged
merged 3 commits into from
May 31, 2021
Merged

Send version and mode to code scanning via user agent #516

merged 3 commits into from
May 31, 2021

Commits on May 31, 2021

  1. Send the version and mode with the user agent 

    This commit changes the way the action determines if running in action
or runner mode. There is now an environment variable that is set at the
beginning of the process and elsewhere in the process, we can check to
see if the variable is set.
    @aeisenberg
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    4758879 View commit details
    Browse the repository at this point in the history

  2. Use the version from package.json in the runner 

    Update the ql queries to account for change in how we look for runner

Previously, we guarded blocks of code to be run by the runner or the
action using if statements like this:

```js
if (mode === "actions") ...
```

We are no longer doing this. And now, the `unguarded-action-lib.ql`
query is out of date. This query checks that runner code does not
unintentionally access actions-only methods in the libraries.

With these changes, we now ensure that code scanning is happy.
    @aeisenberg
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    4164096 View commit details
    Browse the repository at this point in the history

  3. Use the version from package.json in the runner

    @aeisenberg
    aeisenberg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    1a4cdd3 View commit details
    Browse the repository at this point in the history