Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release and mergeback workflows #510
Add release and mergeback workflows #510
Changes from 2 commits
800a951
ea89b06
8b01108
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for the runner? Should it also update the Action's
package.json
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly. This script ensures that when
npm version ...
is called, theversion
script runs and that also triggers thenpm version
on the runner. So, both will be updated in tandem.See
npm help version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. So calling
npm version
at the root will then invoke this script, which bumps the version in the runner. Makes sense.Consider avoiding the
git add .
here, and keeping that in the Actions workflow instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By running
git add .
, this ensures that the version changes to the runner get included in the same commit as the version changes to the containing action. I could rungit commit --amend
in the workflow, but that seems messier if someone is running thenpm version
command manually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Do you know which file it will touch? Perhaps just add the
package.json
file then?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
andpackage-lock.json
. It's pretty safe runningadd .
since the initialnpm version
will fail if the working directory is not clean. I have a slight preference for keeping the.
since this will be more future proof ifnpm version
ever does start touching different files.Also note that the invocation of
npm version patch
in therunner
directory doesn't create a commit since commits are only created if thepackage.json
is in the root of the git repo.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.