When downloading the CodeQL bundle, only use the GitHub AE endpoint on GitHub AE, and check it first. #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgavin
commented
Mar 7, 2021
| @@ -101,9 +101,7 @@ async function run() { | |||
| }; | |||
|
|
|||
| const gitHubVersion = await getGitHubVersion(apiDetails); | |||
| if (gitHubVersion !== undefined) { | |||
There was a problem hiding this comment.
I think these are safe to remove. getGitHubVersion seems to always return an answer.
chrisgavin
force-pushed
the
check-ghae-endpoint-first-only-on-ghae
branch
from
8b7e246
to
ae71f88
Compare
…n GitHub AE, and check it first.
chrisgavin
force-pushed
the
check-ghae-endpoint-first-only-on-ghae
branch
from
ae71f88
to
bb51ece
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the requests to find the CodeQL bundle a bit more efficient. Firstly there's no point trying the GitHub AE endpoint when we're not on GitHub AE, so I've threaded through the GitHub variant and skipped that endpoint unless it's GHAE.
Secondly, if we are on GitHub AE we should check that endpoint first since the other endpoints are much less likely to work.
Merge / deployment checklist