Introduce external repository token #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2021
Closed
chrisgavin
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
This does seem like a fairly neat option to maintain the encapsulation. I'm happy with this method instead of #273.
robertbrignull
force-pushed
the
robertbrignull/external-token-option
branch
from
44bb170
to
97a70e6
Compare
|
I forgot to include a couple of bits of #273 like the changes to the readme and to |
|
I've tested this out locally with a private repository that could only be downloaded by passing the external repository token. It all seems good. |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential alternative to #273 to demonstrate an idea.
Introduces
GitHubApiExternalRepoDetailsandGitHubApiCombinedDetails(names very open to changing) to get us type safety on the different types of api token.Merge / deployment checklist
Closes #273.