Prefer GITHUB_REF to CODE_SCANNING_REF #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcogario
force-pushed
the
marcogario/prioritize_github_ref
branch
from
003b83f
to
a151a3e
Compare
Given that the GITHUB_REF is a protected variable, we want to prefer it to CODE_SCANNING_REF. This should prevent accidentally overwriting these values. The logic is a bit more involved, as I think it makes sense to raise the error about GITHUB_REF not being set, rather than mentioning CODE_SCANNING_REF if both are not set.
marcogario
force-pushed
the
marcogario/prioritize_github_ref
branch
from
a151a3e
to
0a76b97
Compare
edoardopirovano
approved these changes
Nov 16, 2022
This was referenced Nov 16, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
GITHUB_REFis a protected variable, we want to prefer it toCODE_SCANNING_REF. This should prevent accidentally overwriting these values.The logic is a bit more involved, as I think it makes sense to raise the error about
GITHUB_REFnot being set, rather than mentioningCODE_SCANNING_REFif both are not set.Merge / deployment checklist