Delete the runner, part 1 #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now covered by `codescanning-config-cli.yml`.
These are covered by `codeql.yml`, which runs across all latest runner images.
These are tested by `multi-language-autodetect.yml`
These are covered by `autobuild-action.yml`.
Testing SARIF compatibility is covered by `codeql.yml`.
We don't need to test runner functionality now since the runner is only used in PR checks, and `extractor-ram-threads.yml` covers the Action case.
aeisenberg
approved these changes
Nov 15, 2022
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner has been deprecated since March, and has been a long standing piece of tech debt, getting in the way a tiny bit, but not enough to prompt an immediate deletion, when we make changes. Let's finally delete it!
This PR deletes the runner, while #1364 makes several simplifications that are made possible by completely removing the runner.
Commit-by-commit review recommended, I have explained in each commit message why the associated test can safely be removed.
Merge / deployment checklist